fix alias not applying in "through" joins when referencing the same table twice #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve aliases in nested "through" joins when referencing the same table multiple times
While upgrading an older Laravel package and in turn eloquent-power-joins, a few of our queries broke because nested "through" relationships no longer respected table aliases when the same table was joined multiple times.
Example:
Current output (using incorrect alias on the users table):
... inner join "posts" as "posts_alias" on "posts_alias"."user_id" = "users"."id"Expected output (after checking the static cache for the alias on the far parent):
... inner join "posts" as "posts_alias" on "posts_alias"."user_id" = "users_alias"."id"